Skip to content

Fix stale date inputs after Back on /team - #744

Closed
nlewis84 wants to merge 1 commit into
mainfrom
apo-17784-bug-board-team-back-restores-30d-metrics-but
Closed

nlewis84 wants to merge 1 commit into
mainfrom
apo-17784-bug-board-team-back-restores-30d-metrics-but

Conversation

@nlewis84

@nlewis84 nlewis84 commented Nov 18, 2026 •

Copy link
Copy Markdown

🐛 Issue

Fixes APO-17784

On /team, apply custom dates, then use Back to the plain /team page. The heading says "Team metrics · 30d" but Start and End still show the custom dates. The metrics and the inputs disagree.

✏️ Solution

  • Set autoComplete="off" on the Start and End inputs. Chromium was refilling them from history on Back, overriding the server-rendered 30d values. The inputs were already keyed to the window, so this was not a React state bug.
  • Add an e2e test for the apply, reload, Back sequence.

🔬 To Test

  1. Open Team on the PR preview in Chrome
  2. Set Start to 2026-10-01 and End to 2026-10-31, then select Apply dates
  3. Reload the page
  4. Press the browser Back button
  5. Confirm the heading says "Team metrics · 30d" and Start and End show the last 30 days, not October

🧾 Proof

The new e2e test fails on main and passes on this branch. Repro on the fixture build, Start value after Back: main 2026-10-01, branch 2026-10-19.

Desktop light (before) Desktop light (after)
Desktop dark (before) Desktop dark (after)
Phone light (before) Phone light (after)
Phone dark (before) Phone dark (after)

🤖 Generated with Claude Code

Chromium re-fills form fields from history when you go Back, so /team
showed the old custom dates beside the 30d metrics. autocomplete=off
makes the browser keep the server-rendered values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nlewis84
nlewis84 requested a review from redreceipt as a code owner November 18, 2026 15:32
@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

APO-17784

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bug-board Ready Ready Preview Nov 18, 2026 3:33pm UTC

Request Review

@nlewis84

Copy link
Copy Markdown
Author

Closing as a duplicate of #730 (Medic, APO-17700). #730 sets autoComplete="off" on the WindowControls form, and /team and the person pages render that same form. I ran this PR's /team Back test against #730's change alone, and it passes. One fix on the form covers Home, Team and person pages, so this input-level copy isn't needed. Both PRs, like every open bug-board PR, are waiting on #743 to fix the npm audit check.

@nlewis84 nlewis84 closed this Nov 18, 2026
@nlewis84
nlewis84 deleted the apo-17784-bug-board-team-back-restores-30d-metrics-but branch November 18, 2026 15:45

This branch was successfully deployed

1 active deployment
Preview — e49af566 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant